New feature suggestions and BUG #97

Closed
opened 4 years ago by xiaomengxinyo · 38 comments

It is recommended to add the function of screen rounding (not the latest task application card rounding, but the latest task application card rounding already has)

It is recommended to add the function of screen rounding (not the latest task application card rounding, but the latest task application card rounding already has)
Poster

round corner

round corner
Owner

Aren't there 3rd party apps for that?

Aren't there 3rd party apps for that?
Poster

The third-party applications are all overlay layers. When screenshots are taken, there will be black and white things in the four corners. I think it can be realized by modifying systemui.apk, just like the native system, but I don't know which of them is modified

The third-party applications are all overlay layers. When screenshots are taken, there will be black and white things in the four corners. I think it can be realized by modifying systemui.apk, just like the native system, but I don't know which of them is modified
Owner

Rounded corners on my device come from class com.android.systemui.RoundedCorners. I can enable/disable them :) Don't know what else can be done, they are done as images.

Rounded corners on my device come from class *com.android.systemui.RoundedCorners*. I can enable/disable them :) Don't know what else can be done, they are done as images.
Poster

However, many mobile phones do not have com.android.systemui.roundedcores, which can be realized by modifying com.android.systemui

However, many mobile phones do not have com.android.systemui.roundedcores, which can be realized by modifying com.android.systemui
Owner

I checked almost 30 SystemUI apks from different devices, Android 7-10, MIUI 10-11, this class is there in every single one of them. This is the condition to enable rounded corners:

boolean sIsRoundCorner = true;
if (!(SystemProperties.getBoolean("sys.miui.show_round_corner", true) && FeatureParser.getBoolean("support_round_corner", false))) {
    sIsRoundCorner = false;
}

So you can add this line to /system/build.prop:

sys.miui.show_round_corner=true

and this line to /system/etc/device_features/something.xml:

<bool name="support_round_corner">true</bool>

And corners will appear on any device.

I checked almost 30 SystemUI apks from different devices, Android 7-10, MIUI 10-11, this class is there in every single one of them. This is the condition to enable rounded corners: ``` boolean sIsRoundCorner = true; if (!(SystemProperties.getBoolean("sys.miui.show_round_corner", true) && FeatureParser.getBoolean("support_round_corner", false))) { sIsRoundCorner = false; } ``` So you can add this line to **/system/build.prop**: ``` sys.miui.show_round_corner=true ``` and this line to **/system/etc/device_features/something.xml**: ``` <bool name="support_round_corner">true</bool> ``` And corners will appear on any device.
Poster

I've added it and restarted it, but it doesn't work,No round corners.

I've added it and restarted it, but it doesn't work,No round corners.
Poster
There is no content yet.
Poster
There is no content yet.
Poster
There is no content yet.
Owner

Corners are not displayed in one-handed mode (they always apply to whole screen). And vince device has rounded hardware corners, no? This class should already be active there. It just makes them better looking, hardware ones are not perfect. So I don't really understand what you want :)

Corners are not displayed in one-handed mode (they always apply to whole screen). And vince device has rounded hardware corners, no? This class should already be active there. It just makes them better looking, hardware ones are not perfect. So I don't really understand what you want :)
Poster

What I want is that the image after the screenshot is rounded (not that kind of overlay rounded) rather than right angle.

What I want is that the image after the screenshot is rounded (not that kind of overlay rounded) rather than right angle.
Poster

What I want is this effect, but my fillet is a function of the theme I use. It only applies to the desktop, not all.

What I want is this effect, but my fillet is a function of the theme I use. It only applies to the desktop, not all.
Poster

It only applies to miuihome

It only applies to miuihome
Owner

So is it rounded corners in screenshot or in one-handed mode? Screenshot is an image, round corners in Photoshop or some photo edit app :) Corners can only be black overlays, 3rd party apps should work.

So is it rounded corners in screenshot or in one-handed mode? Screenshot is an image, round corners in Photoshop or some photo edit app :) Corners can only be black overlays, 3rd party apps should work.
Poster

Well, I seem to understand. Thank you

Well, I seem to understand. Thank you
Owner

Is your only problem with 3rd party apps that their overlays are visible on screenshots? I can check if it's possible to just hide all overlays before screenshot and then bring them back after.

Is your only problem with 3rd party apps that their overlays are visible on screenshots? I can check if it's possible to just hide all overlays before screenshot and then bring them back after.
Poster

The third-party program can be said to use the hover window permission to cover four circles, of course, the screenshot can be seen. You can add a function that the screenshot will automatically round the image.

The third-party program can be said to use the hover window permission to cover four circles, of course, the screenshot can be seen. You can add a function that the screenshot will automatically round the image.
xiaomengxinyo closed this issue 4 years ago
xiaomengxinyo reopened this issue 4 years ago
Owner

Even default rounded corners by Xiamoi do not round screenshots. I don't want to edit images. Temporarily disabling overlays will result in full rectangular screenshots, you can round them yourself later :)

Even default rounded corners by Xiamoi do not round screenshots. I don't want to edit images. Temporarily disabling overlays will result in full rectangular screenshots, you can round them yourself later :)
Poster

okay,thank you.

okay,thank you.
Poster

Hey, Boss.I found a bug,When the "display icon in settings" switch is turned on, there will be two entrances in the settings, and the entrance near the top is near the bottom, which is the same as the position near the top.

Hey, Boss.I found a bug,When the "display icon in settings" switch is turned on, there will be two entrances in the settings, and the entrance near the top is near the bottom, which is the same as the position near the top.
Owner

What ROM is that? What if you change fast access icon position? Try to kill Settings app and then relaunch. Also send detailed report from module settings.

What ROM is that? What if you change fast access icon position? Try to kill Settings app and then relaunch. Also send detailed report from module settings.
Poster

Redmi 5 Plus.Android8.1.0.MIUI11 9.10.10.Official

Redmi 5 Plus.Android8.1.0.MIUI11 9.10.10.Official
Poster

I found two more bugs.When system notification media settings slider is turned on (use system style is turned on), there are two icons for application details.

I found two more bugs.When system notification media settings slider is turned on (use system style is turned on), there are two icons for application details.
Owner

Both icons open app info or not? It can happen if you updated module and did not reboot.

Both icons open app info or not? It can happen if you updated module and did not reboot.
Owner

Or maybe you already have info icon there without mod? This mod adds 2 bottom icons. 2 top icons should be notification settings and snooze time, but snooze might not be available on your ROM.

Or maybe you already have info icon there without mod? This mod adds 2 bottom icons. 2 top icons should be notification settings and snooze time, but snooze might not be available on your ROM.
Poster

After you turn on application state control,There will be two enable / disable buttons in the application details interface,When you click enable, it will be automatically disabled (the application is in the disabled state, previously disabled),That is to say, it can't be disabled. Clicking disable (application is enabled) is the same. It can't be disabled.There are also two additional information after opening the display application,My com.miui.securitycenter is a beta version.I remember that these bugs are only found in updating modules and com.miui.securitycenter.

After you turn on application state control,There will be two enable / disable buttons in the application details interface,When you click enable, it will be automatically disabled (the application is in the disabled state, previously disabled),That is to say, it can't be disabled. Clicking disable (application is enabled) is the same. It can't be disabled.There are also two additional information after opening the display application,My com.miui.securitycenter is a beta version.I remember that these bugs are only found in updating modules and com.miui.securitycenter.
Poster

Yes, the two icons open the application details, the top left corner is the notification settings, and the bottom right corner is the forced stop application.

Yes, the two icons open the application details, the top left corner is the notification settings, and the bottom right corner is the forced stop application.
Owner

Send detailed report after you tried to enable/disable these apps. It might be because of unsupported Security app version. What is it? 2 disable buttons is not necessarily a bug, first one is a native one and can change to some other actions.

Send detailed report after you tried to enable/disable these apps. It might be because of unsupported Security app version. What is it? 2 disable buttons is not necessarily a bug, first one is a native one and can change to some other actions.
Poster

Report sent.The version of com.miui.securitycenter is beta version, 4.2.0.I've tried to turn off app state control, and there is only one (native button) left for the two enable buttons (app is disabled), and no disable button (app is enabled).

Report sent.The version of com.miui.securitycenter is beta version, 4.2.0.I've tried to turn off app state control, and there is only one (native button) left for the two enable buttons (app is disabled), and no disable button (app is enabled).
Owner

Xposed log has no errors, I need to check that version myself, but no promises. I also need to try that MIUI Launcher 4.16.0.1482 :) It's not even on apkmirror yet.

Xposed log has no errors, I need to check that version myself, but no promises. I also need to try that MIUI Launcher 4.16.0.1482 :) It's not even on apkmirror yet.
Owner

That's the best I can do, just hide 3rd party app overlays on screenshots. Doubt that such mod is very useful :)

That's the best I can do, just hide 3rd party app overlays on screenshots. Doubt that such mod is very useful :)
Poster

okay!thank you!

okay!thank you!
xiaomengxinyo changed title from New feature suggestions to New feature suggestions and BUG 4 years ago
Poster

I want to ask if you can add a gesture to make the current application windowize (I know that not all applications can windowize, but I know that many applications are supported, I added them in the game toolbox, but it's too cumbersome to operate that way). Please.

I want to ask if you can add a gesture to make the current application windowize (I know that not all applications can windowize, but I know that many applications are supported, I added them in the game toolbox, but it's too cumbersome to operate that way). Please.
Owner

You asked that already: #63 How do you make separate windows?

You asked that already: https://code.highspec.ru/Mikanoshi/CustoMIUIzer/issues/63 How do you make separate windows?
Poster

okay

okay
Owner

2.1.3 version has a mod to hide 3rd party overlays on screenshots.

I checked Security 4.2.0 and everything is working fine there, but version from apkmirror.com might be different from yours. Anyway, I'll keep an eye on these mods in future ROM updates.

2.1.3 version has a mod to hide 3rd party overlays on screenshots. I checked Security 4.2.0 and everything is working fine there, but version from apkmirror.com might be different from yours. Anyway, I'll keep an eye on these mods in future ROM updates.
Mikanoshi closed this issue 4 years ago
Poster

OK, thank you very much

OK, thank you very much
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mikanoshi/CustoMIUIzer#97
Loading…
There is no content yet.