Fix scaling issue with systemUi #166

Closed
opened 3 years ago by E-Sy · 7 comments
E-Sy commented 3 years ago

Good Day, First the problem: If the user changes the default dpi (via dev settings) the scaling of systemUI gets incorrect. You can see this very good on the status bar or the new Control Center notification shape: https://xiaomi.eu/community/attachments/screenshot_2020-07-17-02-31-57-066_com-android-settings-jpg.30935/

The solution for me on 488 dpi is to independantly set the SystemUI dpi to 440 and text size of 66%. This fixes all issues. atm I use App Settings Reborn to fix this , but this is a legacy app and has almost no real functions anymore , I would be very happy if this could be integraded into CustoMiuizer

*App Settings is open source https://github.com/BlueCat300/XposedAppSettings

Good Day, First the problem: If the user changes the default dpi (via dev settings) the scaling of systemUI gets incorrect. You can see this very good on the status bar or the new Control Center notification shape: https://xiaomi.eu/community/attachments/screenshot_2020-07-17-02-31-57-066_com-android-settings-jpg.30935/ The solution for me on 488 dpi is to independantly set the SystemUI dpi to 440 and text size of 66%. This fixes all issues. atm I use App Settings Reborn to fix this , but this is a legacy app and has almost no real functions anymore , I would be very happy if this could be integraded into CustoMiuizer *App Settings is open source https://github.com/BlueCat300/XposedAppSettings
Owner

If it's working perfectly why add it to another module?

If it's working perfectly why add it to another module?
E-Sy commented 3 years ago
Poster

It's to trim installed apps also I think CustoMiuizer is more popular than App settings , so maybe a lot of Miui users do not know this app or this very specfic manaul fix. Also there is more math involed as I know atm , the font need to be reduced by 66% this should be always fine if the dpi for systemUI is correct , but what is correct ? 440 from 488 would be 90,16% but if this works in any case , I have no idea.

I think If this would be e.g under System > Bug Fix , It would get the right attention , as changing the DPI to something subjective likeable is mandatory on a new phone in my opinion

It's to trim installed apps also I think CustoMiuizer is more popular than App settings , so maybe a lot of Miui users do not know this app or this very specfic manaul fix. Also there is more math involed as I know atm , the font need to be reduced by 66% this should be always fine if the dpi for systemUI is correct , but what is correct ? 440 from 488 would be 90,16% but if this works in any case , I have no idea. I think If this would be e.g under System > Bug Fix , It would get the right attention , as changing the DPI to something subjective likeable is mandatory on a new phone in my opinion
Owner

I use smallest width 440 dp instead of default 392 and don't notice problems anywhere. What's the problem with status bar? Is it too low? It's like that with any dpi for me.

I use smallest width 440 dp instead of default 392 and don't notice problems anywhere. What's the problem with status bar? Is it too low? It's like that with any dpi for me.
E-Sy commented 3 years ago
Poster

Well, If the dpi is changed not everything gets eqaly good scaled, for example, the font size is set to a user defined value but get sometimes additionaly smaller respectivly to the fixed dpi size (in systemUI cases , including system pop-ups, statusbar, fingerpint icon etc) Maybe the differents in your case is too small to be noticed. But you should atleast see that the upper grid (Data, Bluetooth , Mobile , Wlan) is not equaly spaced in H and V

Correcting this lead to a Better and Intentend way how miui Should look like With changed dpi

I will provide a before and after image to make things more obvious

( What's the problem with status bar? Is it too low? It's like that with any dpi for me

That's propably a surfaceflinger bug I have seen it adjusting the statusbar hide , I had fixed this for me a while back with some build.prop values but don't have them any more for varius reasons but you could start the search there for a bug fix if you want to )

Well, If the dpi is changed not everything gets eqaly good scaled, for example, the font size is set to a user defined value but get sometimes additionaly smaller respectivly to the fixed dpi size (in systemUI cases , including system pop-ups, statusbar, fingerpint icon etc) Maybe the differents in your case is too small to be noticed. But you should atleast see that the upper grid (Data, Bluetooth , Mobile , Wlan) is not equaly spaced in H and V Correcting this lead to a Better and Intentend way how miui Should look like With changed dpi I will provide a before and after image to make things more obvious ( What's the problem with status bar? Is it too low? It's like that with any dpi for me That's propably a surfaceflinger bug I have seen it adjusting the statusbar hide , I had fixed this for me a while back with some build.prop values but don't have them any more for varius reasons but you could start the search there for a bug fix if you want to )
Owner

Well, everything is becoming smaller, Control Center layout is terrible with any dpi, that's why I don't use it and don't mod it. Everything else seems normal, don't know what do you want me to do.

Well, everything is becoming smaller, Control Center layout is terrible with any dpi, that's why I don't use it and don't mod it. Everything else seems normal, don't know what do you want me to do.
E-Sy commented 3 years ago
Poster

I like the new control center, scaled right I looks very good.

Well I dont want you to do anything, I asked If you could add this fix to your app, but if you cant see that the UI gets messed up with different DPIs, or its not important for YOU, I cant help it. Sorry but I wasted alot of time trying to explain to you something visually so obvious.

I'm done here Good Day

(pls grab a book about desgin and read it)

I like the new control center, scaled right I looks very good. Well I dont want you to do anything, I asked If you could add this fix to your app, but if you cant see that the UI gets messed up with different DPIs, or its not important for YOU, I cant help it. Sorry but I wasted alot of time trying to explain to you something visually so obvious. I'm done here Good Day (pls grab a book about desgin and read it)
Owner

(pls grab a book about desgin and read it)

Tell it to Xiaomi devs.

> (pls grab a book about desgin and read it) Tell it to Xiaomi devs.
Mikanoshi closed this issue 3 years ago
Mikanoshi locked as Resolved and limited conversation to collaborators 3 years ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Mikanoshi/CustoMIUIzer#166
Loading…
There is no content yet.